Phumudzo/fix/date format #1527
Closed
Phumudzo/fix/date format #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIlyichev
requested changes
May 16, 2024
There was a problem hiding this comment.
Hi @nthangeniphumudzo. Range pickers are broken. Also we should use start of the periods (e.g. start of the day for date only, start of the week for weeks etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @IvanIlyichev . I revisted the issue and here is my new approach.
I know you don't want manipulation of the "localValue" before transimission/submission, but in this instance I am not change it I am just making sure the data sent is aligned with UTC and avoiding that transformation happening in .Json() on submission where we won't have control all together.
here is the link to the issue