Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fallback for all custom properties #5

Closed
shgysk8zer0 opened this issue Aug 5, 2017 · 0 comments · Fixed by #7
Closed

Use fallback for all custom properties #5

shgysk8zer0 opened this issue Aug 5, 2017 · 0 comments · Fixed by #7
Assignees
@shgysk8zer0
Labels
enhancement

Comments

@shgysk8zer0
Copy link
Owner

CSS allows for a fallback value in var(--my-prop). Since this does not she should not provide defaults, use fallbacks instead.
@shgysk8zer0 shgysk8zer0 self-assigned this Aug 5, 2017
shgysk8zer0 added a commit that referenced this issue Aug 8, 2017
@shgysk8zer0
Add custom property fallbacks
b583e18 
Resolves #5
- Add default values for all `var()` usage
- Move all font icon related CSS into own stylesheet
- Exception for font for `<details>` (need CSS shapes)
- Remove links.css (rules in misc.css & font-icons.css)
@shgysk8zer0 shgysk8zer0 mentioned this issue Aug 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shgysk8zer0 shgysk8zer0

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fallbacks for custom properties shgysk8zer0/core-css
1 participant
@shgysk8zer0