update

shiba6v · Jul 14, 2019 · b16218a · b16218a
1 parent 30ad5a7
commit b16218a
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -3,4 +3,11 @@
 ## Installation
 ```
 jupyter nbextension install https://github.com/shiba6v/jupyter-shape-commentator/archive/master.zip --user
+```
+
+
+## Installation for Development
+```
+cd /path/to
+jupyter nbextension install . --user
 ```
diff --git a/jupyter-shape-commentator.js b/jupyter-shape-commentator.js
@@ -15,14 +15,28 @@ define([
         }
 
         function shape_erase(){
-            var parent = document.getElementsByClassName("end_space")[0];
-            while (parent.firstChild) {
-                parent.removeChild(parent.firstChild);
+            // var parent = document.getElementsByClassName("end_space")[0];
+            // while (parent.firstChild) {
+            //     parent.removeChild(parent.firstChild);
+            // }
+            // var cell = Jupyter.notebook.get_selected_cell();
+            // var orig_text = cell.get_text();
+            // cell.set_text("%%shape_erase"+"\\n"+orig_text);
+            // cell.execute();
+            var output_callback = function (out_data){
+                console.log(out_data);
+            };
+            var callbacks = {
+                iopub: {
+                    output: output_callback
+                }
             }
-            var cell = Jupyter.notebook.get_selected_cell();
-            var orig_text = cell.get_text();
-            cell.set_text("%%shape_erase"+"\\n"+orig_text);
-            cell.execute();
+            var options = {
+                silent: false,
+                store_history : true,
+                stop_on_error: false
+            };
+            cell.notebook.kernel.execute(code, callbacks, options);
         }
         function load_ipython_extension() {
             // if (document.getElementById('shape_commentator_button')!=null){

diff --git a/jupyter-shape-commentator.yaml b/jupyter-shape-commentator.yaml
@@ -2,4 +2,5 @@ Type: IPython Notebook Extension
 Name: Jupyter Shape Commentator
 Description: You can add shape comments to your code.
 Link: README.md
-Main: jupyter-shape-commentator.js
+Main: jupyter-shape-commentator.js
+Compatibility: 4.x, 5.x