Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing user-agent header in Acme Requests? (BuyPass Acme API) #678

Closed
FredrikMelby opened this issue Mar 5, 2024 · 2 comments · Fixed by #679
Closed

Missing user-agent header in Acme Requests? (BuyPass Acme API) #678

FredrikMelby opened this issue Mar 5, 2024 · 2 comments · Fixed by #679
Assignees
Labels
bug Something isn't working

Comments

@FredrikMelby
Copy link

Describe the bug
We are receiving http400 errors from BuyPass Acme API when we try to renew or create new certificates. I have been in contact with their support, and they have made a change to their Acme API being more strict with the user-agent header:
image
(https://community.buypass.com/t/p8y833j/get-http-bad-request-from-acme-api#x2y881l)

"ACME clients MUST send a User-Agent header field, in accordance with
[RFC7231]. This header field SHOULD include the name and version of
the ACME software in addition to the name and version of the
underlying HTTP client software."

Is this maybe the case here?

BuyPass API: https://api.buypass.com/acme/directory

See #671 for related information.

@shibayan
Copy link
Owner

shibayan commented Mar 5, 2024

Thanks for the report. I was able to confirm that the certificate fails to issue with BuyPass in my environment as well, so I added the User-Agent so that it works correctly.

A fixed version will be released shortly.

@FredrikMelby
Copy link
Author

Thanks for quick fix again. Tested OK here now as well 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants