Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: the description for MacBERT. #259

Merged
merged 8 commits into from Mar 2, 2022
Merged

Conversation

okcd00
Copy link
Contributor

@okcd00 okcd00 commented Mar 1, 2022

Thank you for your contribution and sharing! This repo is nice for researchers on CSC tasks.
I also want to participate in, this time I'd like to update the introduction about MacBERT:

The actual MacBERT used in this project does not have the same framework with SoftMaskedBert,
this commit corrects the description of MacBERT in the README file.

A figure for introducing MacBERT is also uploaded into /docs/git_image from the original paper:

macbert_samples

A temporary figure for the MacBERT in this repo:
macbert_network

The actual MacBERT used in this project is not SoftMaskedBert, this commit corrects the description of MacBERT in the README file.
The actual MacBERT used in this project is not SoftMaskedBert, this commit corrects the description of MacBERT in the README file.
Upload a simple figure for the network structure of MacBERT in this repo.
@shibing624
Copy link
Owner

update network structure:

  1. FC-> classifier + softmax
  2. bert mlm
  3. weighted sum -> loss expression
  4. add output, is correction word, crossentropy.

Add more detailed introductions.
@okcd00
Copy link
Contributor Author

okcd00 commented Mar 2, 2022

How about this one?

macbert_network

@shibing624 shibing624 merged commit 2c7f06f into shibing624:master Mar 2, 2022
@shibing624
Copy link
Owner

thank you. pr merged.

@okcd00
Copy link
Contributor Author

okcd00 commented Mar 2, 2022

Thank you for your patient answers. ^_^

And sorry for a faulty linking in my PR:
in README.md#L441 and pycorrector/macbert/README.md#L9
the postfix of the figure file for MacBERT should be .jpg, not .png.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants