Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Turkish translations #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bitigchi
Copy link
Contributor

@shidel, I'm not sure if it's a recent addition or not, but the strings in fdi-x86 has quotes around strings, but rather strangely. They do not seem to include the space preceding and trailing the variable placeholder. Could you please have a look at my example couple of strings, and tell if I'm doing it alright?

@shidel
Copy link
Owner

shidel commented Jul 13, 2023

@bitigchi, I quickly looked over the submission. There are a couple issues which I'll comment on directly in a few minutes. But, mostly they look fine.

Generally speaking quotations are not needed with only a few exceptions. (I think one of the translators added them for improved readability.)

  • To use the switch character (/) in text it must be quoted.
  • To use a quote style character (or apostrophe), the parameter must wrapped in a different quote character. For example, to print a " character, wrap them in a single quote like 'He said, "Hello!"' And to use an apostrophe (single quote), wrap them in quotation marks. Like "Go to Bob's House."
  • To force spacing or additional spacing in a string of text. For example, hello there my friend would display hello there my friend. But, using " hello there" "my friend" will output hello there my friend

Variable/parameters (like %1) are always expanded wether or not they are inside or outside of quotation marks. To use a percent symbol, simple enter %%.

On a side note, if you are unsure how something is going to displayed, you can use VECHO directly to preview the most text. It is what displays the translation text for the batch based programs. For example, to display the default welcome message for FDI-x86, you can run vecho /t setup.en WELCOME_DEF 1 2 which displays Welcome to the 1 2 installation program.. You just need to provide something to populate the required variables. Since extra variables are ignored. you could just make a simple test like this...

@echo
REM T.BAT for testing V8Power Tools translation resources files
REM Opt1-Opt8 are used to populate the resource string variables
REM Standard V8Power tools quotation rules apply to those. 
REM For example, to have spaces in those parameters, they could
REM be "opt 1" "opt 2" ....
vecho /t setup.tr %1 Opt1 Opt2 Opt3 Opt4 Opt5 Opt6 Opt7 Opt8

Then a simple "t.bat WELCOME_ADV" would output Welcome to the Opt1 Opt2 installation program.

Just be aware, there can be options given to VECHO before the resource string is loaded. For example:

vecho /bBlue /e /n /r5 /c32 /t setup.tr %1 Opt1 Opt2

Which would first set the background to Blue (/bBlue) Clear the remainder of the line (/e) and set the background color to Blue, disable printing a CRLF when finished (/n) , then Repeating 5 times (/r5) Writing a space character (/c32) ... Then the resource string would be processed.

Things get a little more complicated with the FDI main installer because it supports themes. Some of the varables passed are not displayed text but are color options. And, care must be taken not to enclose them in quotation marks. However, those can be identified by a preceding color switch of /f or /b. For example /f %1 is a color change and not displayed text. So, perhaps for the test batch this might be better...

vecho /t setup.tr %1 1 2 3 4 5 6 7 8

Colors can be set by name or value. /fRed, /f red, /F4, /f 4, /f0x4, etc. are all equivalent.

Ugh.

:-)

Jerome

@@ -82,7 +81,7 @@ GATHERING="Kurulum haz
# STAGE800 - Installing
INSTALL_FRAME=/w62 /h10 /c
INSTALL_OPTS=/w48 /h5 /c
INSTALL=/s- /f %1 "%2" /f %3 " art�k kurulabilir."
INSTALL=/s- /f %1 "%2" /f %3 " art�k kurulabilir.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing end quote.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this is an interesting string. Actually it should be like this innit:

INSTALL=/s- /f %1 '%2' /f %3 "art�k kurulabilir."

The space before artık seems unnecessary. I changed the original double quotes around %2 to single quotes, to make it more understandable, that it is surrounded by literal quotes.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space before artık seems unnecessary.

Well that's a tricky one. :-)

Let's assume %2 equals FreeDOS

The /s- turns off spacing between parameters. So, /s- /f %1 '%2' /f %3 "art�k kurulabilir." would display FreeDOSart�k kurulabilir. because no space will be inserted between the '%2' and the following text string.

So the space after the quote forces one. Don't know why a /s- was placed in there. Looking at the BAT file that uses that string it does not modify the spacing behaviour.

vecho /k0 /t %FLANG% INSTALL %TFH% "%OS_NAME% %OS_VERSION%" %TFF%
(FLANG is the language file, TFH and TFF are theme color values and OS_NAME + OS_VERSION are in quotes and passed as a single parameter.)

Possibly, a long time ago that invocation turn off spacing and the /s- in the translation file was just a reminder of the state. However, it would have been better to use /s+ to turn back on spacing.

So, remove the /s- from the string and the space following the quote won't be needed.

An example of /s- behaviour...

vecho A B /s- C D E "F G" "H" /s+ I J "K L" "M N" displays A BCDEF GH I J K L M N

BACKUPADV_OPTS=/w45 /h5 /c
BACKUP=/f %1 %2 /f %3 " s�r�c�s�nde kurulu bir i�letim sistemi bulundu."
BACKUP?="Kurulumdan �nce mevcut dosyalar� yedeklemek ister misiniz?"
BACKUP=/f %1 %2 /f %3 /s- s�r�c�s�nde kurulu bir i�letim sistemi bulundu.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not want to use the /s- switch here. That switch turns off spacing between parameter strings and would cause all the words to run together as one. I'm not sure why there was a space in the original quoted string. But, it should be fine without it. So either of these should be fine...

BACKUP=/f %1 %2 /f %3 s�r�c�s�nde kurulu bir i�letim sistemi bulundu.
or
BACKUP=/f %1 %2 /f %3 "s�r�c�s�nde kurulu bir i�letim sistemi bulundu."

DELETE_OPTS=/w42 /h5 /c
DELETE?=/f %1 %2 /f %3 "s�r�c�s�ndeki t�m eski dosyalar kald�r�ls�n m�?"
DELETE?=/f %1 %2 /f %3 /s- s�r�c�s�ndeki t�m eski dosyalar kald�r�ls�n m�?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to use /s- here.

DELETEY=" Evet, her �eyi kald�r"
DELETEN=" Hay�r, �ylece b�rak"

# FDASK500 - Advanced mode transfer system files
XFER_FRAME=/w60 /h8 /c
XFER_OPTS=/w45 /h5 /c
XFER?=Yeni sistem dosyalar� /f %1 %2 /f %3 " s�r�c�s�ne aktar�ls�n m�?"
XFER?=Yeni sistem dosyalar� /f %1 %2 /f %3 /s- s�r�c�s�ne aktar�ls�n m�?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to use /s- here.

Copy link
Owner

@shidel shidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly the changes look good. Just one missing trailing quotation and a couple places where you added an unwanted /s-.

Although I think frame/boxes look better when they are just big enough, I always get worried about making them smaller. So, we will just need to make sure they are big enough in one of the following Interim Test Builds. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants