Capture surrogate keys and pass them to a front-end application. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,6 +77,12 @@ def path(params = nil, record = nil) | |||
| super(params) | |||
| end | |||
|
|
|||
| def capture_surrogate_keys | |||
| Thread.current[:shift_surrogate_keys] = nil | |||
There was a problem hiding this comment.
This needs to be
Thread.current[:shift_surrogate_keys] = []
yield
results = Thread.current[:shift_surrogate_keys].uniq.join(' ')
Thread.current[:shift_surrogate_keys = nil)
results
| @@ -7,10 +7,8 @@ def call(environment) | |||
| surrogate_keys = env.response_headers['external-surrogate-key'].split(' ') if env.response_headers['external-surrogate-key'] | |||
|
|
|||
| if surrogate_keys | |||
There was a problem hiding this comment.
You have an unless inside an if here which could be tidied up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a middleware to capture Fastly surrogate keys, as supplied to the server, and store them for passing onto a client. We use this so that we can output Matalan pages with these surrogate keys to assist in Fastly caching, as described in https://github.com/shiftcommerce/matalan-rails-site/issues/633.