chore(deps): add xUnit console runner #16
Conversation
BrainCrumbz
commented
Nov 30, 2016
BrainCrumbz
commented
- chore(tools): add xUnit console runner
- chore(deps): upgrade xUnit to 2.1.0
- chore(deps): upgrade Shouldly to 2.8.2
- chore(tools): upgrade solution to VS 2013
| @@ -1,6 +1,8 @@ | |||
| | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio 2012 | |||
| # Visual Studio 2013 | |||
There was a problem hiding this comment.
I'm fine with bringing this up to VS2015, if that helps...
There was a problem hiding this comment.
Well, we had both installed on a machine, but started opening with 2013 ... I guess it's ok for now. If VS2015 should somehow be needed, than we can switch to that.
|
There's a minor package restore issue as part of the build process (which seems to then trigger a MSBuild warning): https://ci.appveyor.com/project/shiftkey/reactive-eventaggregator/build/1.1.37#L33 Not sure if you're worried about that. |
BrainCrumbz
changed the title
|
Retitled PR, as the main need was to actually be able to run tests from console. Upgrading xUnit was just a needed step in the middle. |
|
Re. the restore issue, I think it is due to the included nuget executable in .nuget folder, which by now is an old version. The real solution to that would be to drop local nuget.exe and .nuget folder altogether, as that approach is discouraged by now. Don't remember though what happens to build.ps1. If it's ok for you, I'd go for a merge, and possibly fix this issue in a separate commit/branch from you/my team/whoever. |
|
@BrainCrumbz thanks for this!
|
|
This PR is just instrumental to the one we were mainly interested in, about upgrading Rx. Which is under way. |
