option to use Windows title bar on Linux

[Heath123]

#139 added this, but was reverted (#149).

Proposed solution

Personally I (and probably some others) prefer the Windows-style title bar, so it would nice if there was a configuration option of some kind.

[shiftkey]

@Heath123 thanks for opening this up.

For the moment this is a low-priority for me as I initially thought this would be straight-forward but #149 showed how many people tweaked their setups (and I'd inadvertently affected). I also heard in #243 that these client-side decorations didn't fit with their setup.

I'd like to hear from others why the Windows-style theme here is preferred for them - others shared their setups in #149, like #149 (comment), so I'm curious if we can avoid having to juggle multiple options.

[Heath123]

Personally I like it because I think custom title bars look quite nice and professional, it saves a tiny bit of space (not really a big deal) and it's sort of funny to see a Windows-like window on Ubuntu, I don't know about other people, though. This is a really small thing and I don't care that much, so it makes sense that it's low-priority. I wonder if many other people want this or if it's mostly just me?

[harry-cpp]

I personally prefer the CSD, I use Ubuntu 20.04 + GNOME.

[GrahamSH-LLK]

This would be so awesome. Leaving it up to the OS is not my favorite choice as some Linux dists are absolutely ugly.

[GrahamSH-LLK]

One idea is to not put the close/minimize/maximize there and leave that up to the OS. That way we minimize annoyance on both sides. A less "windowsy" one would be better also.

[mon-jai]

Wanted this feature too. The current one is ugly on Ubuntu.

[Miqueas]

Wanted this feature too. The current one is ugly on Ubuntu.

Is ugly on ANY distro/desktop environment

[Miqueas]

@shiftkey the best solution here is to provide an option to enable/disable CSD and ship the app as-is (like vs code)

[Miqueas]

From my point of view, this is a waste of space, since everything in the server-side decorated title bar can be in the same place as the app menu bar

[Miqueas]

Still no changes? :(

[shiftkey]

Still no changes? :(

The relevant code is linked in the other pull requests, but I've marked this as "help wanted" as I'd like someone to take a shot at making it configurable.

[Miqueas]

Still no changes? :(

The relevant code is linked in the other pull requests, but I've marked this as "help wanted" as I'd like someone to take a shot at making it configurable.

Oh, that makes sense

[mon-jai]

@shiftkey Maybe we could just additionally, make another build with Windows titlebar?

[mon-jai]

@shiftkey Did a quick look.

Seems that their configuration stores lies within the browser side of the boundary. But if we will need the config value before the browser window is even created,

desktop/app/src/main-process/app-window.ts

Lines 62 to 67 in 5d1d4b7

	} else if (__LINUX__) {
	windowOptions.frame = false
	windowOptions.icon = path.join(__dirname, 'static', 'icon-logo.png')
	}
	this.window = new BrowserWindow(windowOptions)

Maybe we could write the config value to a file? (like `${app.getPath('userData')}/electron-config.json`)