revert using in-app menu and fallback to default window chrome #237
Conversation
|
+1 for giving control of the application menu back to GTK. Here's how it looks in XFCE with the
|
|
I'm all with the default window chrome, but is it possible for this to be user configurable?. I think some would prefer the in-app menu. I think this will satisfy all users. |
It is possible, but I want to avoid that unless there's serious interest in both states.
I was the one to submit this PR because of how the app looked by default (this borrowed from how the app looks on Windows, which I felt made sense for the situation), but maybe I'm in the minority? That's why I'd like feedback here... |
|
|
||
| // A mixin which takes a content block that should only | ||
| // be applied when the current (real or emulated) operating | ||
| // system is Linux. | ||
| // | ||
| // This helper mixin is useful in so far that it allows us | ||
| // to keep platform specific styles next to cross-platform | ||
| // styles instead of splitting them out and possibly forgetting | ||
| // about them. | ||
| @mixin linux { | ||
| body.platform-linux & { | ||
| @content; | ||
| } | ||
| } | ||
|
|
||
| // An exact copy of the linux mixin except that it allows for | ||
| // writing base-level rules | ||
| @mixin linux-context { | ||
| body.platform-linux { | ||
| @content; | ||
| } | ||
| } |
There was a problem hiding this comment.
While how the titlebar is styled doesn't matter to me either way, you'll likely still have some linux specific styling to apply (see my PR on styling scrollbars for dark mode), so I'd recommend keeping these mixins
There was a problem hiding this comment.
@jfgordon2 good point, but for now I'm going to leave this revert as-is as it makes rebasing to drop the original commit easier. I'll add the theming mixins in a follow-up PR that should support your work in #240.
So far several 👍 and no objections to this change, so I might wrap this up tomorrow so I can prepare an update that contains several improvements from the previous week. |
|
Well I'm late, I personally preferred the CSD version, the non CSD version looks quite ugly on GNOME. |
|
@harry-cpp the discussion is continuing over in #285 if you'd like to share more about your setup |
|
You linked to an issue about a bug with menus and fullscreen? Is that the right link? |
|
@harry-cpp off by one - I meant #285 - apologies |
Reverts #139
Resolves #149
linuxto drop original commit from future releasesLight theme
Dark theme
I'd like to get some feedback from users that this is their desired behaviour, so please 👍 or 👎 this PR to confirm this is what you prefer. I plan to leave this open until April 11 to ensure everyone has a chance to review this.