Snap: use system theme and xwayland #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue #98 |
shiftkey
force-pushed
the
linux
branch
2 times, most recently
from
60d258c
to
8f06643
Compare
shiftkey
force-pushed
the
linux
branch
5 times, most recently
from
dda9127
to
ed1acbb
Compare
shiftkey
force-pushed
the
linux
branch
2 times, most recently
from
bf0e4f5
to
ea0619d
Compare
valerierx
approved these changes
Mar 20, 2019
|
@joshirio thanks for this contribution. I'm going to publish a build today with these changes so that others can test and confirm the packaging is working as expected! |
|
Just to add a comment. I'm surprised to see the mouse cursor theme working correctly: I'll investigate it to find out why on other electron based projects it doesn't, maybe it's because of the additional plugs. Nice to learn some new things 😀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
the snap doesn't launch under Wayland, I propose these changes which at the moment is the standard way to get it running by using XWayland until electron supports Wayland natively. Additionally the added plugs let the snap use the default system gtk and icon theme when available as snap (like Yaru, Ambiance, Adwaita).
I contributed recently the same changes to another electron app which now works fine, except the cursor theme still being ugly (fallback theme), please see the following discussions for more details:
vladimiry/ElectronMail#104 (comment)
vladimiry/ElectronMail#109