Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move icons to correct location, update usages in tooling #606

Merged
merged 1 commit into from
Oct 3, 2021

Conversation

shiftkey
Copy link
Owner

@shiftkey shiftkey commented Oct 3, 2021

Resolves #559

Thanks to @sarim for identifying the root cause.

The bit that I'd forgotten as part of this is that static assets need to be defined in a platform-specific subdirectory to be included as part of the app package - app/static/win32 for Windows, app/static/darwin for macOS and app/static/linux for Linux.

This is the relevant code that does the actual copying:

desktop/script/build.ts

Lines 253 to 255 in c7c2cf6

if (fs.existsSync(platformSpecific)) {
fs.copySync(platformSpecific, destination)
}

app/static/logos is only used at packaging time, which is why things were working sometimes.

I also found out that the icon option for electron-packager is not supported on Linux, so I've updated that area to be clearer.

@shiftkey shiftkey force-pushed the move-icons-to-correct-directory branch from fa8f82c to 9543083 Compare October 3, 2021 21:25
@shiftkey shiftkey merged commit 2587066 into linux Oct 3, 2021
@shiftkey shiftkey deleted the move-icons-to-correct-directory branch October 3, 2021 21:49
imgbot bot pushed a commit to hamzasgd/desktop that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After installation 2.9.0 icon does not appear
1 participant