This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
force-pushed
the
sketching-out-api
branch
from
September 7, 2017 03:49
660c957
to
7760b2e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent a bunch of time with
mleech/scotch
yesterday and learned a bunch, but wanted to start from scratch with consuming thevcr
on-disk format rather than remembering how to F# all over again.Goals to prove out in tests:
After that, I'll start breaking this up into a proper API.
Other interesting formats that might be useful here are nock (example fixtures) but this is a slightly different variant on JSON storage, so I'm trying to make this as pluggable as possible while it's early on.
I also want to borrow the use of a
VCR_MODE
environment variable thatphilscatz/fetch-vcr
uses to control the runtime behaviour of tests.This means one unified implementation, rather than swapping things out on-the-fly in tests.