Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalVideo のスポットライトフォーカス時のスタイルを修正する #554

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

tnamao
Copy link
Contributor

@tnamao tnamao commented Jun 17, 2024

変更履歴

  • [FIX] LocalVideo のスポットライトフォーカス時の表示を修正する
    • CSS クラスの指定が正しくなかった
    • @tnamao

Copy link

cloudflare-pages bot commented Jun 17, 2024

Deploying sora-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: 204d698
Status: ✅  Deploy successful!
Preview URL: https://fa1bffb4.sora-devtools.pages.dev
Branch Preview URL: https://feature-local-video-spotligh.sora-devtools.pages.dev

View logs

@tnamao tnamao requested a review from torikizi June 17, 2024 06:18
Copy link
Contributor

@torikizi torikizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます。
以下のプラットフォームとブラウザで動作を確認し、スポットライト時にセルフビューにフォーカスが当たっていることを確認できました。

実行コーデック

  • VP8
  • VP9
  • AV1
  • H.264
  • H.265

※ AV1 / H.265 は動作環境のみ

  • macOS
    • Safari
    • Firefox
    • Edge
    • Chrome
  • Windows
    • Firefox
    • Edge
    • Chrome
  • iOS
    • Safari
  • Android
    • Chrome

@tnamao
Copy link
Contributor Author

tnamao commented Jun 17, 2024

確認ありがとうございます
マージします

@tnamao tnamao merged commit cea1f9b into develop Jun 17, 2024
8 checks passed
@tnamao tnamao deleted the feature/local-video-spotlight branch June 17, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants