Feature/fix type offer message #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voluntas
force-pushed
the
feature/fix-type-offer-message
branch
from
e606037
to
db70ee4
Compare
voluntas
force-pushed
the
feature/fix-type-offer-message
branch
from
db70ee4
to
f5f8be9
Compare
tnamao
reviewed
Jul 9, 2024
tnamao
approved these changes
Jul 9, 2024
|
|
|
@tnamao デフォルト値を追加しました。 |
|
LGTM 👍 |
voluntas
added a commit
that referenced
this pull request
Jul 9, 2024
* type: offer 時のシグナリングメッセージの型定義を修正する * type: offer 時の処理の追加と、simulcast の判定を options ではなくする * type: offer 時の処理の追加と、simulcast の判定を options ではなくする * 変更履歴を更新する * 変更履歴を更新する * session_id は互換性を考慮してオプションとする * 接続状態の初期化のデフォルト値を追加
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"type": "offer"のsimulcastの値が反映されていない問題を修正する"type": "offer"のbundle_idとspotlightを保持するように修正するThis pull request mainly introduces changes to the
ConnectionBaseclass inpackages/sdk/src/base.tsand updates theCHANGES.mdfile. The modifications in theConnectionBaseclass involve adding new properties and updating methods to incorporate these properties. TheCHANGES.mdfile has been updated to reflect these changes.Updates to
ConnectionBaseclass:packages/sdk/src/base.ts: Addedsimulcast,spotlight, andbundleIdas new properties in theConnectionBaseclass. These properties are initialized in the constructor andinitializeConnectionmethod. They are also updated in thesignalingOnMessageTypeOffermethod. [1] [2] [3] [4] [5]packages/sdk/src/base.ts: Updated the condition for simulcast in the anonymous function within thepc.getTransceivers().findcall to use the newsimulcastproperty.Updates to
SignalingOfferMessagetype:packages/sdk/src/types.ts: Addedmultistream,simulcast,simulcast_multicodec,spotlight, andbundle_idto theSignalingOfferMessagetype.Changes in
CHANGES.md:CHANGES.md: Added entries for fixing issues where"type": "offer"did not reflect thesimulcast,bundle_id, andspotlightvalues.