fix #493: pass method-wise type arguments to methods #495

yhara · 2023-07-08T14:38:22Z

This PR adds method-wise type arguments to llvm method functions so that it can be referred for type arguments (eg. Array<A>.new) or just like p A.

fix #493

Change arity of LLVM functions of methods that have method typarams
- eg. for Enumerable#map<S>, add parameter S after normal parameters
Fix codegen of method calls to pass a class object for that S
- To do this, add expression to get S to HirMethodCall
Fix gen_tvar_ref to get the value from llvm function parameter
- TODO: what if we are in a lambda? →capture it like local variables

Since .owner never have type arguments (i.e. never be a specialized type), Erasure is sufficient. Also, you can get TermTy from an Erasure but not from a TypeFullname.

if the method tyarg is refered in the lambda.

should pass `true` for readoly flag...

Added tyargs to func type

for method calls other than generic_new too

- wrong: `tp.upper_bound` i.e. `%Object*` - right: `%Meta:Object`

_get_nth_tyarg_of_self generates `%Class*`. This should be bitcasted to the upper bound (currently always `Meta:Object*`).

yhara force-pushed the pass-method-tyarg branch 2 times, most recently from ea49f25 to 2e3ecb9 Compare July 18, 2023 03:53

yhara force-pushed the pass-method-tyarg branch 2 times, most recently from 879f005 to 101c257 Compare July 21, 2023 05:00

yhara added 15 commits July 21, 2023 17:33

PR

72d215e

Add method-typarams to llvm functions

09981c2

wip: Change FoundMethod.owner to ty::Erasure

aa13a15

Since .owner never have type arguments (i.e. never be a specialized type), Erasure is sufficient. Also, you can get TermTy from an Erasure but not from a TypeFullname.

Add tyarg_exprs to Hir::method_call

59fda91

Add comment

d7d5b1d

fix: Add a hack for .new

8fbd402

wip: impl. HirMethodTVarRef

72611fe

Add error report

04eb1cd

Lambdas should capture method-wise tyarg

7eb3171

if the method tyarg is refered in the lambda.

Add debug helper

b61decc

Improve debug message

5e8308b

fix: method tyargs are readonly

6e19f25

should pass `true` for readoly flag...

fix: was bitcasting to wrong func type

ab52b83

Added tyargs to func type

Add test

7165651

fix: Pass tyargs to module methods too

e2f97d5

yhara force-pushed the pass-method-tyarg branch from 5094c38 to e2f97d5 Compare July 21, 2023 09:03

yhara added 10 commits July 22, 2023 19:28

Merged class_expr into get_class_object

701c695

Edit comment

0abfc9c

Infer method-wise type arguments

d7e9d4d

for method calls other than generic_new too

fix: get_class_object should consider const_is_obj

db579d7

Add test

b779198

fix: bitcast needed when returning a subclass instance

772120a

TyParam.upper_bound should be LitTy

503c72f

Fix type of captured method tyarg

551c383

fix type of method tyarg in llvm function args

2369a2e

- wrong: `tp.upper_bound` i.e. `%Object*` - right: `%Meta:Object`

fix: missing bitcast

16752d8

_get_nth_tyarg_of_self generates `%Class*`. This should be bitcasted to the upper bound (currently always `Meta:Object*`).

yhara changed the title ~~wip: fix #493~~ fix #493: pass method-wise type arguments to methods Jul 24, 2023

yhara marked this pull request as ready for review July 24, 2023 05:15

yhara merged commit 7d52b06 into main Jul 24, 2023
4 checks passed

yhara deleted the pass-method-tyarg branch July 24, 2023 05:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix #493: pass method-wise type arguments to methods #495

fix #493: pass method-wise type arguments to methods #495

yhara commented Jul 8, 2023 •

edited

fix #493: pass method-wise type arguments to methods #495

fix #493: pass method-wise type arguments to methods #495

Conversation

yhara commented Jul 8, 2023 • edited

yhara commented Jul 8, 2023 •

edited