Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking change: Remove unused type parameters from enum case #514

Merged
merged 6 commits into from Aug 25, 2023
Merged

breaking change: Remove unused type parameters from enum case #514

merged 6 commits into from Aug 25, 2023
+53 −34

Conversation

yhara
Copy link
Collaborator

@yhara yhara commented Aug 25, 2023

This PR removes unused type parameters from enum cases. For example, Result::Fail<V> is changed to just Result::Fail because Fail does not depend on V.

enum Result<V>
  case Ok(value: V)
  case Fail(err: Error)

@yhara
Changed supertype of Fail
2a0a6a5 
- before: `Result::Fail<V> : Result<V>`
- after: `Result::Fail : Result<Never>`

Removed type parameters of an enum case which are not used in the
constructor parameters.
@yhara
fix: type_index should calculate the typarams too
d053bcb
@yhara
fix signature of .new of enum cases
e4828d0
@yhara
Remove tyargs for Fail
cf9bd02
@yhara
Improve Error#to_s
abe683a
@yhara
fix test
1db8df5
@yhara yhara merged commit 64d5708 into main Aug 25, 2023
4 checks passed
@yhara yhara deleted the fail-tyarg branch August 25, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yhara