Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced gateId by gateName as per version 8.4. as it is deprecated. #67

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

vinod827
Copy link
Contributor

Refer https://sonarqube.inria.fr/sonarqube/web_api/api/qualitygates

POST api/qualitygates/select do not support gateId anymore and it has been deprecated. The new parameter is gateName.

Tested the change with SonarQube CE version 8.9.9. There are no more integers in the quality gates like 100, 827, etc it is alpha-numeric now and treated as a String.

@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vinod827
Copy link
Contributor Author

@shijl0925 I would really appreciate if you can review this PR at the earliest as it is a blocker for us.

@vinod827
Copy link
Contributor Author

@shijl0925 pls review it

@shijl0925 shijl0925 merged commit 89163e0 into shijl0925:master Nov 27, 2022
@vinod827
Copy link
Contributor Author

vinod827 commented Nov 27, 2022

@shijl0925 please do a package version release of 1.3.5 as well

@shijl0925
Copy link
Owner

@vinod827
Copy link
Contributor Author

@vinod827
Copy link
Contributor Author

@shijl0925 this is very interesting...just for my knowledge purpose, may I know how it got quickly released on the official, pypi site? https://pypi.org/project

Are you using any pipeline or GitHub Actions for that? Is there any Wiki page/documentation link that I can read about it.

@vinod827
Copy link
Contributor Author

@shijl0925 please refer attached screenshot. I have a doubt here. Should not be version 1.3.5 here?
Screenshot 2022-11-28 at 10 26 28 AM

shijl0925 added a commit that referenced this pull request Jun 6, 2023
Replaced gateId by gateName as per version 8.4. as it is deprecated.
shijl0925 added a commit that referenced this pull request Jun 6, 2023
Replaced gateId by gateName as per version 8.4. as it is deprecated.
shijl0925 added a commit that referenced this pull request Jun 8, 2023
Replaced gateId by gateName as per version 8.4. as it is deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants