Skip to content

Commit

Permalink
make the bounding boxes halfway between the previous point and the ne…
Browse files Browse the repository at this point in the history
…xt point. fixes issue w3c#98.
  • Loading branch information
tlatorre-uchicago committed Aug 27, 2014
1 parent aac6efb commit 4c30477
Showing 1 changed file with 14 additions and 22 deletions.
36 changes: 14 additions & 22 deletions js/metrics-graphics.js
Expand Up @@ -1310,37 +1310,29 @@ charts.line = function(args) {
}
})
.attr('x', function(d, i) {
var current_x = d;
var x_coord;

if (i == 0) {
var next_x = args.data[0][1];
x_coord = args.scalefns.xf(current_x)
- (args.scalefns.xf(next_x) - args.scalefns.xf(current_x))
/ 2;
}
else {
var width = args.scalefns.xf(args.data[0][1])
- args.scalefns.xf(args.data[0][0]);

x_coord = args.scalefns.xf(current_x) - width / 2;
return args.scalefns.xf(d);
} else {
var prev = args.scalefns.xf(args.data[0][i-1]);
return (prev + args.scalefns.xf(d))/2;
}

return x_coord;
})
.attr('y', function(d, i) {
return (args.data.length > 1)
? args.scalefns.yf(d) - 6 //multi-line chart sensitivity
: args.top;
})
.attr('width', function(d, i) {
if (i != args.data[0].length - 1) {
return args.scalefns.xf(args.data[0][i + 1])
- args.scalefns.xf(d);
}
else {
return args.scalefns.xf(args.data[0][1])
- args.scalefns.xf(args.data[0][0]);
if (i == 0) {
var next = args.scalefns.xf(args.data[0][i+1]);
return (next - args.scalefns.xf(d))/2;
} else if (i == args.data[0].length - 1) {
var prev = args.scalefns.xf(args.data[0][i-1]);
return (args.scalefns.xf(d) - prev)/2;
} else {
var next = args.scalefns.xf(args.data[0][i+1]);
var prev = args.scalefns.xf(args.data[0][i-1]);
return (next-prev)/2;
}
})
.attr('height', function(d, i) {
Expand Down

0 comments on commit 4c30477

Please sign in to comment.