Skip to content

Commit

Permalink
Fix issue w3c#398
Browse files Browse the repository at this point in the history
  • Loading branch information
almossawi committed Mar 30, 2015
1 parent dac567d commit 7321248
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 10 deletions.
9 changes: 5 additions & 4 deletions dist/metricsgraphics.js
Expand Up @@ -152,6 +152,7 @@
missing_text: 'Data currently missing or unavailable',
scalefns: {},
scales: {},
show_tooltips: true,
show_missing_background: true,
interpolate: 'cardinal'
};
Expand Down Expand Up @@ -3439,8 +3440,8 @@
}

//trigger mouseover on all points for this class name in .linked charts
if (args.linked && !globals.link) {
globals.link = true;
if (args.linked && !MG.globals.link) {
MG.globals.link = true;

//trigger mouseover on matching point in .linked charts
d3.selectAll('.mg-voronoi .path-' + i)
Expand Down Expand Up @@ -3479,8 +3480,8 @@
var svg = mg_get_svg_child_of(args.target);

return function(d,i) {
if (args.linked && globals.link) {
globals.link = false;
if (args.linked && MG.globals.link) {
MG.globals.link = false;

d3.selectAll('.mg-voronoi .path-' + i)
.each(function() {
Expand Down
6 changes: 3 additions & 3 deletions dist/metricsgraphics.min.js

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions examples/charts/data.html
Expand Up @@ -71,10 +71,10 @@

<pre><code class='javascript'>MG.data_graphic({
title: "Glorious Graphic",
description: "This is an example of a graphic whose data is currently missing. We've also set the <i>error</i> option, which appends an error icon to the title and logs an error to the browser's console.",
error: 'This data is blocked by Lorem Ipsum. Get your **** together, Ipsum.',
chart_type: 'missing-data',
missing_text: 'This is an example of a missing chart',
description: "This is an example of a graphic whose data is currently missing. We've also set the <i>error</i> option, which appends an error icon to the title and logs an error to the browser's console.",
target: '#glorious_chart',
width: 600,
height: 200
Expand Down Expand Up @@ -171,10 +171,10 @@

MG.data_graphic({
title: "Glorious Graphic",
error: 'This data is blocked by Lorem Ipsum. Get your **** together, Ipsum.',
chart_type: 'missing-data',
missing_text: 'This is an example of a missing chart',
description: "This is an example of a graphic whose data is currently missing. We've also set the <i>error</i> option, which appends an error icon to the title and logs an error to the browser's console.",
error: 'This data is blocked by Lorem Ipsum. Get your **** together, Ipsum.',
missing_text: 'This is an example of a missing chart',
target: '#glorious_chart',
width: 600,
height: 200
Expand Down
1 change: 1 addition & 0 deletions src/js/common/data_graphic.js
Expand Up @@ -139,6 +139,7 @@ MG.data_graphic = function() {
missing_text: 'Data currently missing or unavailable',
scalefns: {},
scales: {},
show_tooltips: true,
show_missing_background: true,
interpolate: 'cardinal'
};
Expand Down

0 comments on commit 7321248

Please sign in to comment.