Merge pull request w3c#213 from blazkovicz/custom-missing-text

missing_text now an arg for the 'missing-data' chart
shikhar-scs · Nov 20, 2014 · a8ac673 · a8ac673
2 parents 42fd2e7 + cb0c28e
commit a8ac673
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 13 deletions.
diff --git a/js/metricsgraphics.js b/js/metricsgraphics.js
@@ -131,7 +131,8 @@ function data_graphic() {
         right: 0,
         left: 0,
         width: 350,
-        height: 220
+        height: 220,
+        missing_text: 'Data currently missing or unavailable'
     }
 
     var args = arguments[0];
@@ -2345,17 +2346,15 @@ charts.missing = function(args) {
             .attr('width', args.width - (args.left * 2))
             .attr('height', args.height - (args.top * 2));
 
-        var missing_text = 'Data currently missing or unavailable';
-
         // add missing text
-        svg.selectAll('.missing_text').data([missing_text])
+        svg.selectAll('.missing_text').data([args.missing_text])
           .enter().append('text')
             .attr('class', 'missing-text')
             .attr('x', args.width / 2)
             .attr('y', args.height / 2)
             .attr('dy', '.50em')
             .attr('text-anchor', 'middle')
-            .text(missing_text)  
+            .text(args.missing_text)
 
         return this;
     }

diff --git a/js/metricsgraphics.min.js b/js/metricsgraphics.min.js
diff --git a/src/charts/missing.js b/src/charts/missing.js
@@ -26,17 +26,15 @@ charts.missing = function(args) {
             .attr('width', args.width - (args.left * 2))
             .attr('height', args.height - (args.top * 2));
 
-        var missing_text = 'Data currently missing or unavailable';
-
         // add missing text
-        svg.selectAll('.missing_text').data([missing_text])
+        svg.selectAll('.missing_text').data([args.missing_text])
           .enter().append('text')
             .attr('class', 'missing-text')
             .attr('x', args.width / 2)
             .attr('y', args.height / 2)
             .attr('dy', '.50em')
             .attr('text-anchor', 'middle')
-            .text(missing_text)  
+            .text(args.missing_text)
 
         return this;
     }

diff --git a/src/common/data_graphic.js b/src/common/data_graphic.js
@@ -132,7 +132,8 @@ function data_graphic() {
         right: 0,
         left: 0,
         width: 350,
-        height: 220
+        height: 220,
+        missing_text: 'Data currently missing or unavailable'
     }
 
     var args = arguments[0];