New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support server-url to specify api server #35
Conversation
https://github.com/ParsePlatform/parse-server Parse will not host api server after 2017/1/28
include is not a function in 'should', using endWith instead
lots of bugs in new API-SERVER, so test failed object __type check is missing role name check is missing. Role names must be specified. code 135 file/push implementation is changed user get will get addtional info ACL user test failed by recovable session is required
Thanks for this. I will look into this properly before merging. |
+1 |
I also need this, 👍 +1 |
modify test to fit the origin/new parse server support revocable session which is enable by default
I modify test to fit original/new parse server as best as I can. https://github.com/sdf611097/parse-server-example.git U can run cmd below in parse-server-example to start local env for parse server. After that, execute below cmd in kaiseki to run the test with this env but there are still 3 failure
This is little different from original, doesn't matter.
This test is also failed in the origin test, but response is different.
this one should fail with 'To push to ios devices, you must first configure a valid certificate.' but I'm not familiar with push, maybe is due to my local env is empty, the target is empty so that pass. |
@shiki will this pr be accepted, merged and npm publish a new kaiseki version? |
}; | ||
|
||
Kaiseki.prototype = { | ||
API_BASE_URL: 'https://api.parse.com', | ||
var DEFAULT_MOUNT_PATH = '/1'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't you just put the /1
as part of the serverUrl
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open-source ParseServer can specified mount path. Parse.com use /1, and the example use /parse. So the serverUrl is combination of host-server(:port) and its mount path. "api.parse.com/1" and "localhost:1337/parse"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn't that just the same as giving a server url with the "/1"
or the "/parse"
though?
new Kaiseki(.... "api.parse.com/1")
or
new Kaiseki(... "localhost:1337/parse")
I am. I'm having trouble to actually get this to work with the default parse server. I think we should have something that does not require a customized parse-server repository. I'll push this in a different branch for now and work on that branch. Do you think we should just have revocable sessions turned on by default and not let that get configured? That's probably gonna make things less complicated. |
Revocable sessions turn on by default is ok. I think it should be configurable, or it will not compatible with legacy-sessions. Someone are trying to let parse-server support legacy token. Maybe I separate the commits? Configurable first, then support switch parse-server url? I think we should have something that does not require a customized parse-server repository. I do not catch this sentence. Sorry for my poor English. |
Don't worry about it. I pushed this to the parse-server branch for now. I am trying to get this working using the default config from https://github.com/ParsePlatform/parse-server-example. I'll merge the |
If you have any problem, plz let me know. |
This has been merged to |
Thanks for your merge and publish. ^^ |
lots of bugs in new API-SERVER, so test failed
object __type check is missing
role name check is missing. Role names must be specified. code 135
file/push implementation is changed
users get will get additional ACL info
user test failed by recovable session is required
newServerTest.sh need start local ParseServer.
You can start it from
https://github.com/sdf611097/parse-server-example.git
sh kaiseki.sh