Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang): add alias dockerfile -> docker #444

Merged
merged 1 commit into from Mar 24, 2023
Merged

feat(lang): add alias dockerfile -> docker #444

merged 1 commit into from Mar 24, 2023

Conversation

ezracelli
Copy link
Contributor

Adds an alias language ID dockerfile for language ID docker. This provides parity with GHFM (which actually doesn’t support docker, only dockerfile), GLFM, and Prism


  • I have read docs for adding a language.
  • N/A — I have searched around and this is the most up-to-date, actively maintained version of the language grammar.
  • N/A — I have added a sample file that includes a variety of language syntaxes and succinctly captures the idiosyncrasy of a language. See docs for requirement.

@netlify
Copy link

netlify bot commented Mar 9, 2023

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 0c1d98d
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/640a229e7a1f6a0008a1ce05
😎 Deploy Preview https://deploy-preview-444--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -314,6 +314,7 @@ export const languageAliases = {
clojure: ['clj'],
codeql: ['ql'],
csharp: ['c#', 'cs'],
docker: ['dockerfile'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: This was the only change made manually, all other changes were made automatically by ./scripts/grammars/updateGrammarSourceFiles.ts

@ezracelli
Copy link
Contributor Author

Not sure why CI is failing here, looks like playwright is complaining about a version mismatch? Bit out of my wheelhouse, but doesn’t seem like this PR should have touched anything related to that 😅

@octref
Copy link
Collaborator

octref commented Mar 24, 2023

Sorry, fixed CI and rebased.

@octref
Copy link
Collaborator

octref commented Mar 24, 2023

Can't push the rebase change to your branch – next time can you check the box that "allows maintainers to push"?
The current changes are minimal and look good, so I'll just merge it now.

@octref octref merged commit 4189136 into shikijs:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants