Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shellsession grammar #483

Merged
merged 2 commits into from Jun 26, 2023

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jun 13, 2023

  • Format all commit messages with Conventional Commits
  • I have read docs for adding a language.
  • I have searched around and this is the most up-to-date, actively maintained version of the language grammar.
  • I have added a sample file that includes a variety of language syntaxes and succinctly captures the idiosyncrasy of a language. See docs for requirement.

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 5ca0772
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/6498954187511d0008f28dd2
😎 Deploy Preview https://deploy-preview-483--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@octref
Copy link
Collaborator

octref commented Jun 25, 2023

Hi! Thanks for your contribution – what's the difference between shellsession and shellscript? Can you also add a sample file for shellsession?

@mashehu
Copy link
Contributor Author

mashehu commented Jun 25, 2023

shellsession usually just highlight the command prompt, e.g. the first line of the output but not the whole output. I hope the sample make sit clearer.

@octref
Copy link
Collaborator

octref commented Jun 26, 2023

Makes sense. Thanks for your work 👍

@octref octref merged commit 8774e57 into shikijs:main Jun 26, 2023
3 checks passed
@mashehu mashehu deleted the add-shellsession-language branch June 26, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants