Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add glimmer js/ts language #486

Merged
merged 5 commits into from Jun 25, 2023
Merged

Conversation

IgnaceMaes
Copy link
Contributor

@IgnaceMaes IgnaceMaes commented Jun 20, 2023

  • Format all commit messages with Conventional Commits
  • I have read docs for adding a language.
  • I have searched around and this is the most up-to-date, actively maintained version of the language grammar.
  • I have added a sample file that includes a variety of language syntaxes and succinctly captures the idiosyncrasy of a language. See docs for requirement.

Adds support for .gjs and .gts file formats. Glimmer <template> tag components are the new format which power Ember.js. References:

Local test:

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 0c4195f
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/6492a39278c6c90008e5e69e
😎 Deploy Preview https://deploy-preview-486--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@IgnaceMaes IgnaceMaes mentioned this pull request Jun 20, 2023
5 tasks
Copy link
Collaborator

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you 🚀

@octref octref merged commit acde095 into shikijs:main Jun 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants