Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findHomography is missing an overload and USAC methods are missing. #1396

Closed
JoanCharmant opened this issue Mar 9, 2022 · 0 comments · Fixed by #1398
Closed

findHomography is missing an overload and USAC methods are missing. #1396

JoanCharmant opened this issue Mar 9, 2022 · 0 comments · Fixed by #1398
Labels
enhancement New feature or request

Comments

@JoanCharmant
Copy link

JoanCharmant commented Mar 9, 2022

Hi,

It seems the following overload to findHomography is missing:

Mat cv::findHomography (InputArray srcPoints, InputArray dstPoints, OutputArray mask, const UsacParams &params)

Declaration.

It makes use of the cv::UsacParams structure which is also not wrapped as far as I can tell.

Furthermore, the HomographyMethods enum passed to the existing Cv2.FindHomography is missing the new USAC values.

As can be seen here in the implementation, the cv::findHomography is capable of understanding the new methods (USAC_DEFAULT, USAC_PARALLEL, USAC_FAST, etc.) so I think these should be added to the HomographyMethods enum, or it should be merged with RobustEstimationAlgorithms as I don't think there are any differences at openCV level (?).

The wrapped method is also missing the last two parameters int maxIters and double confidence which have default values at the C++ level.

Thanks!

@shimat shimat added the enhancement New feature or request label Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants