You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm running this action on Gitea, and today I have discovered Gitea saves secrets with cr/lf Windows style endings, which makes git clone fail, even though I run Gitea via Docker, and none of my computers have Windows:
Load key "/root/.ssh/id_rsa": invalid format
git@git.example.com: Permission denied (publickey).
fatal: Could not read from remote repository.
I had to add this extra step to fix the issue:
- name: Fix SSH keyrun: sed -i 's/\r$//g' /root/.ssh/id_rsa
I do realize this issue is on Gitea side, which I will report, but would appreciate if you could implement same functionality but within this action and add one extra config option, for such scenarios. Like:
Apparently this is not Gitea related issue, but rather browser: whatwg/html#6647
I work on Chrome, and seems like Chrome converts to crlf endings, which means if one adds ssh key into repository secrets, it is impossible to use this key without such a fix which I mentioned above.
Based on these facts, I think stripping cr from ssh key by default would be great.
I'm running this action on Gitea, and today I have discovered Gitea saves secrets with cr/lf Windows style endings, which makes
git clone
fail, even though I run Gitea via Docker, and none of my computers have Windows:I had to add this extra step to fix the issue:
I do realize this issue is on Gitea side, which I will report, but would appreciate if you could implement same functionality but within this action and add one extra config option, for such scenarios. Like:
Thanks!
The text was updated successfully, but these errors were encountered: