Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make up for LF in last line of SSH key file #156

Merged
merged 1 commit into from
Feb 21, 2021
Merged

Make up for LF in last line of SSH key file #156

merged 1 commit into from
Feb 21, 2021

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Sep 6, 2020 •
edited

#147

  • append additional test
    • convert PEM to OpenSSH
    • remove last LF

@tats-u tats-u marked this pull request as draft September 6, 2020 17:18
@tats-u
Copy link
Contributor Author

tats-u commented Jan 23, 2021

Waiting for #157 & #164 to be fixed.

@MatthiasKunnen
Copy link

Might I ask why this PR is blocked by #164?

@tats-u
Copy link
Contributor Author

tats-u commented Feb 11, 2021

@MatthiasKunnen This is because CIs triggered by ALL PRs from ANYONE other than the author ALWAYS fail. We can NEVER tell whether they are due to us or not.

@shimataro shimataro changed the base branch from develop to feature/ssh-key-lf February 21, 2021 06:43
@shimataro shimataro marked this pull request as ready for review February 21, 2021 06:57
@shimataro shimataro merged commit 0ea914c into shimataro:feature/ssh-key-lf Feb 21, 2021
@shimataro
Copy link
Owner

@MatthiasKunnen
Secrets won't be passed to non-author's actions; PRs/pushs/etc.
It's for security reason.

@tats-u
Thank you for your PR, I've unlocked draft and merged into my branch.
I will check your PR on the branch.

@shimataro shimataro mentioned this pull request Feb 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tats-u @MatthiasKunnen @shimataro