Remove node_moudles/@actions directories from tracked files & directories list
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.4 to 1.2.6. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The list can be fetched by `gibo dump node`.
tats-u
force-pushed
the
ignore-node-modules
branch
from
0bb0d36
to
f8c3712
Compare
tats-u
force-pushed
the
ignore-node-modules
branch
from
f8c3712
to
18a8f3b
Compare
Remove & ignore previous one (lib/main.js{,.map})
tats-u
force-pushed
the
ignore-node-modules
branch
from
18a8f3b
to
f8b8fa0
Compare
tats-u
changed the title
node_moudles/@actions directories from ttracked files & directories listnode_moudles/@actions directories from tracked files & directories list
|
Failed builds are caused by #164 , so these failed builds will be passed after merged. |
tats-u
force-pushed
the
ignore-node-modules
branch
from
2625d1f
to
f8b8fa0
Compare
Author's key is not passed to PR builds (shimataro#164)
tats-u
force-pushed
the
ignore-node-modules
branch
from
6b72eff
to
5957928
Compare
shimataro
changed the base branch from
develop
to
feature/ignore-node-modules
|
@tats-u I may amend your code because I have't examine carefully for now. しばらく放置していてごめんなさい！ まだコードを詳しく見ていないので、あとでこちらで手を加えるかもしれません。 |
|
Thank you for your consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157
You do not have to add
node_modulesto Git. It is not recommended.https://devcenter.heroku.com/ja/articles/node-best-practices#only-git-the-important-bits (Japanese)
It may cause some troubles in the future.
https://okinawanpizza.hatenablog.com/entry/2020/01/01/224337 (Japanese)
VSCode recommends us to add
node_modulesto.gitignore.ncc can pack dependencies into a compiled
.jsfile (tscitself cannnot), so you do not have to includenode_modules/@actionsin your repository anymore.After this PR is merged, we only have to run
npm install.