Themes broken in GTK>=3.19 #120

nonamedotc · 2016-03-13T20:03:45Z

Due to recent updates in GTK-3.19+[1], greybird themes do not have the clean appearance they usually have. I believe this requires an update to greybird incorporating changes in GTK-3.19+

[1] https://blogs.gnome.org/mclasen/2015/11/20/a-gtk-update/

ochosi · 2016-03-15T00:07:12Z

Yes, Greybird doesn't support Gtk+ 3.19 yet and since it will be a rewrite of the theme I guess I won't get to it very soon.
That said, if anyone wants to start working on that, that'd be appreciated!

JotaRandom · 2016-04-12T01:27:43Z

I should add bug for bluebird and albatross and orion too, or (indifferent if greybord is the priority) this bug is enough to keep users aware of the problem in the themes?

ghost · 2016-04-12T17:15:08Z

I'm using XFCE 4.12 + Greybird v1.6.2 and I can confirm that its broken with latest upgrade of GTK3. Most notably its broken when using Firefox v45.

@ochosi "Yes, Greybird doesn't support Gtk+ 3.19 yet and since it will be a rewrite of the theme I guess I won't get to it very soon." That too bad, as I've been using this greybird theme for many years. Now I'm forced to find alternatives at least until its fixed. =((

JotaRandom · 2016-04-14T23:49:22Z

I was reading some forums and may guys point that in the mailist of gnome they mentioned that gtk 3.22 will change some theming part will change again and likely break theming but in a less ugly way.
But I can't find in the mailist the reference, but anyway, beware, maybe better look for gtk3.21 instead.

ghost · 2016-04-15T05:00:30Z

I'm using "arc-dark" (https://github.com/horst3180/Arc-theme) as an alternative for now. Also using Faenza Icons (http://tiheum.deviantart.com/art/Faenza-Icons-173323228) and Firefox theme "arc-darker" (https://github.com/horst3180/arc-firefox-theme) Firefox theme is also available on (https://addons.mozilla.org/en-US/firefox/themes/)

ochosi · 2016-04-16T20:38:59Z

@jristz Actually pretty much every Gtk+3 release so far broke the theming...

Note that 3.20 is still fairly new and as I'm on Ubuntu, it'll take a few more months for me to get it and to work on the necessary updates.

Furthermore, I'm planning to rewrite the theme from scratch based on Adwaita and in SASS for better maintainability (the css is slowly but surely getting unreadable). If any of you want to help, please contribute and send pull requests!

corsac-s · 2016-04-17T09:34:43Z

I've submitted PR #125 but it's far from complete and maybe not the right way at all (duplicating code all around).

louwers · 2016-05-20T00:55:27Z

I sincerely believe that this is the most ergonomic, pragmatic and beautiful GTK theme around. I doubt I will be able to be of much help because I have zero experience with GTK themes, but I will see what I can do.

Thank you for your effort on this. 👍

ochosi · 2016-05-22T19:57:07Z

@louwers Thanks for the praise!

kuboosoft · 2016-05-31T07:29:08Z

Hi, I love greybird theme, but in Fedora 24 XFCE (Gtk 3.20.6) doesn't display, edges in buttons, contextual menus and others

cinquecento · 2016-06-06T23:07:39Z

Upstream: Greybird GTK-3.20 port - based on Adwaita theme
https://bugzilla.redhat.com/attachment.cgi?id=1167162

Greybird GTK+ 3.20 port - based on Adwaita theme,
incl. lightdm-gtk-greeter.css GTK+ 3.20 port
For testing purposes only!

How to test it:

download theme and patch it

$ mkdir -p ~/.themes
$ cd ~/.themes
$ git clone https://github.com/shimmerproject/Greybird.git Greybird-GTK+3.20
$ cd Greybird-GTK+3.20/
$ curl -s https://bugzilla.redhat.com/attachment.cgi?id=1167162 | git apply

switch to theme

$ xfconf-query -c xsettings -p /Net/ThemeName -s Greybird-GTK+3.20
$ xfconf-query -c xfwm4 -p /general/theme -s Greybird-GTK+3.20

set as LightDM GTK+ Greeter theme (moreover, available to all users)

$ su -c "cp -a ../Greybird-GTK+3.20 /usr/share/themes/"
$ su -c "sed -i '/^theme-name/ a\theme-name=Greybird-GTK+3.20' /etc/lightdm/lightdm-gtk-greeter.conf"

cinquecento · 2016-06-06T23:39:33Z

A couple of references ...

MATE Desktop themes
https://github.com/mate-desktop/mate-themes

The Adwaita theme
https://git.gnome.org/browse/gtk+/tree/gtk/theme/Adwaita

GtkParasite Css Editor
https://github.com/chipx86/gtkparasite

Live Editing GTK CSS With GTK-Parasite | Just Sweet!
http://worldofgnome.org/live-editing-gtk-css-with-gtk-parasite-just-sweet

Rename parasite to gtkinspector
https://git.gnome.org/browse/gtk+/commit/?id=ccff3e9

GtkInspector Css Editor
https://git.gnome.org/browse/gtk+/tree/gtk/inspector

GtkInspector
https://wiki.gnome.org/Projects/GTK%2B/Inspector

Introducing GtkInspector
https://blogs.gnome.org/mclasen/2014/05/15/introducing-gtkinspector

Tweaking a the GTK+ theme, using CSS
https://blogs.gnome.org/mclasen/2014/05/06/tweaking-a-the-gtk-theme-using-css

to paraphrase,
... ask not what your theme can do for you, ask what you can do for your theme.

ilikenwf · 2016-06-18T23:22:20Z

@cinquecento I can confirm that the 3.20 patch works well on my system.

Archlinux, XFCE4 and gtk3 3.20.6

PKGBUILD if anyone wants it: http://sprunge.us/MgdC

jEsuSdA · 2016-06-21T10:32:34Z

I've just install the 20160619 package version and it works fine, but there are several bugs on certain buttons and fields (see the synaptic screenshot and look at the buttons, search field and menu).

Thanks for your work!! Greybird is awesome!!

jEsuSdA · 2016-06-21T10:36:09Z

Another app with issues I've just detected: Synfig

ochosi · 2016-06-28T08:59:14Z

Sorry to respond so late, I was fairly busy lately.

Thanks for your contribution! I looked at the patch and I guess this could work, but it's not a very maintainable solution. If you look at the shear length of the contained.css file and the amount of selectors and nodes in some lines, that's so far from readable...

I guess the only way to move forward is - and in that respect the approach was correct - to rebase on top of Adwaita, however also using Adwaita's system (SCSS/SASS). Otherwise we'll always fight with unreadable walls of text.

I also realize that if I don't get to porting Greybird to the system laid out above everyone else will still need some sort of working version in the meantime, so I might end up pushing the patch by poma until I have something better.

ochosi · 2016-06-29T07:32:05Z

As I'm about to start testing the patch myself I also pushed it to a branch so it's easier for others to try it out:
https://github.com/shimmerproject/Greybird/tree/gtk3.20

ochosi · 2016-07-04T11:10:22Z

Just to let you all know, I've set up Gtk3.20 for myself and I've started the porting fun. Please forget about the branch I mentioned above, I'll delete it shortly.

securerootd · 2016-07-11T05:09:05Z

@cinquecento This patch works perfectly 👍
I am back with Greybird on Debian Stretch

ochosi · 2016-07-18T07:09:27Z

OK, finally some news on this. Here's my WIP version of Greybird for Gtk3.20. There are several tweak-worthy and missing things (like proper theming of lightdm-gtk-greeter) but I hope that it will mostly work for everyone without eye-bleeding.
https://github.com/shimmerproject/Greybird/tree/gtk3.20

For all those waiting, sorry it took so long.

Hope I can do a first release of this soon.

Please note that I will likely not do any more maintenance releases or backports for Gtk<=3.18. The changes were just too dramatic.

jEsuSdA · 2016-07-20T16:54:01Z

It works fine! 👍
I'll notify you if I found any bug. ;)
Thank you so much!!!

codeforkjeff · 2016-07-21T22:23:31Z

This is looking fantastic, many thanks for your work on this!

FYI, the vertical scrollbar doesn't display correctly for me in Firefox 47.0.1 on Debian testing (stretch). It just looks like a single solid gray bar. In other applications (xfce terminal and gimp, just to pick two at random), the scrollbar displays fine.

jbicha · 2016-07-21T22:50:14Z

@codeforkjeff Where did you install your Firefox from? firefox-esr included in Debian testing works fine here with greybird built from the gtk-3.20 branch.

codeforkjeff · 2016-07-21T22:57:10Z

@jbicha I'm using a tarball I downloaded from the Mozilla website. Starting with Firefox 46, the official tarballs are compiled against gtk3. The firefox-esr package in Debian testing is at 45.2.0.

jbicha · 2016-07-21T22:59:01Z

Firefox 47 does not support GTK 3.20 and has bugs like the scrollbar issue you mentioned. You need at least Firefox 48 (currently in Beta) although some bugs aren't fixed until 49.

jbicha · 2016-07-21T23:00:55Z

Alternatively, if you're compiling it yourself, you could stay with 47 and grab the GTK 3.20 patch from, say, Fedora.

codeforkjeff · 2016-07-21T23:09:07Z

@jbicha Thanks for the info! I just tried the 48b07 tarball from the Beta downloads section, and it does indeed fix the scrollbar issue. So definitely not a Greybird problem.

ochosi · 2016-08-16T09:00:00Z

Merged to master, hence this is fixed: 688b10c

nonamedotc changed the title ~~Themes look broken in GTK-3.19+~~ Themes broken in GTK-3.19+ Mar 13, 2016

nonamedotc mentioned this issue Apr 11, 2016

Gtk 3.20 broke Greybird #123

Closed

ochosi changed the title ~~Themes broken in GTK-3.19+~~ Themes broken in GTK>=3.19 Apr 11, 2016

nonamedotc mentioned this issue Apr 14, 2016

Support for GTK 3.20 #124

Closed

ochosi mentioned this issue Apr 26, 2016

Broken with firefox 45 #126

Closed

ochosi closed this as completed Aug 16, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Themes broken in GTK>=3.19 #120

Themes broken in GTK>=3.19 #120

nonamedotc commented Mar 13, 2016

ochosi commented Mar 15, 2016

JotaRandom commented Apr 12, 2016

ghost commented Apr 12, 2016

JotaRandom commented Apr 14, 2016

ghost commented Apr 15, 2016

ochosi commented Apr 16, 2016

corsac-s commented Apr 17, 2016

louwers commented May 20, 2016

ochosi commented May 22, 2016

kuboosoft commented May 31, 2016

cinquecento commented Jun 6, 2016 •

edited

cinquecento commented Jun 6, 2016

ilikenwf commented Jun 18, 2016 •

edited

jEsuSdA commented Jun 21, 2016

jEsuSdA commented Jun 21, 2016

ochosi commented Jun 28, 2016

ochosi commented Jun 29, 2016

ochosi commented Jul 4, 2016

securerootd commented Jul 11, 2016

ochosi commented Jul 18, 2016 •

edited

jEsuSdA commented Jul 20, 2016

codeforkjeff commented Jul 21, 2016

jbicha commented Jul 21, 2016

codeforkjeff commented Jul 21, 2016

jbicha commented Jul 21, 2016

jbicha commented Jul 21, 2016

codeforkjeff commented Jul 21, 2016

ochosi commented Aug 16, 2016

Themes broken in GTK>=3.19 #120

Themes broken in GTK>=3.19 #120

Comments

nonamedotc commented Mar 13, 2016

ochosi commented Mar 15, 2016

JotaRandom commented Apr 12, 2016

ghost commented Apr 12, 2016

JotaRandom commented Apr 14, 2016

ghost commented Apr 15, 2016

ochosi commented Apr 16, 2016

corsac-s commented Apr 17, 2016

louwers commented May 20, 2016

ochosi commented May 22, 2016

kuboosoft commented May 31, 2016

cinquecento commented Jun 6, 2016 • edited

cinquecento commented Jun 6, 2016

ilikenwf commented Jun 18, 2016 • edited

jEsuSdA commented Jun 21, 2016

jEsuSdA commented Jun 21, 2016

ochosi commented Jun 28, 2016

ochosi commented Jun 29, 2016

ochosi commented Jul 4, 2016

securerootd commented Jul 11, 2016

ochosi commented Jul 18, 2016 • edited

jEsuSdA commented Jul 20, 2016

codeforkjeff commented Jul 21, 2016

jbicha commented Jul 21, 2016

codeforkjeff commented Jul 21, 2016

jbicha commented Jul 21, 2016

jbicha commented Jul 21, 2016

codeforkjeff commented Jul 21, 2016

ochosi commented Aug 16, 2016

cinquecento commented Jun 6, 2016 •

edited

ilikenwf commented Jun 18, 2016 •

edited

ochosi commented Jul 18, 2016 •

edited