Fix the huge default margins in GTK+3 statusbar #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is hardcoded in the UI file: https://github.com/GNOME/gtk/blob/gtk-3-22/gtk/ui/gtkstatusbar.ui#L6 So the default margins have to be subtracted from the desired margin. This is inspired by how the Canta theme fixes it: https://github.com/vinceliuice/Canta-theme/blob/db96a1e27e131e4a0fad1e7e2b656179db46b5e8/src/_sass/gtk/apps/_mate.scss#L286 The large size results in various bug reports and issues like: https://bugs.eclipse.org/bugs/show_bug.cgi?id=456345 zim-desktop-wiki/zim-desktop-wiki#342 geany/geany#1825 https://unix.stackexchange.com/questions/271042/gtk3-statusbar-height And C-based fixes like: https://git.xfce.org/apps/ristretto/commit/?id=289329 I've read that this has been fixed in Cinnamon and Unity themes, presumably in a similar fashion, but I don't have any of those to test.
houndci-bot
reviewed
Aug 3, 2019
| @@ -1326,6 +1326,15 @@ searchbar, | |||
| } | |||
|
|
|||
|
|
|||
| /*************** | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hardcoded in the UI file:
https://github.com/GNOME/gtk/blob/gtk-3-22/gtk/ui/gtkstatusbar.ui#L6
So the default margins have to be subtracted from the desired margin.
This is inspired by how the Canta theme fixes it:
https://github.com/vinceliuice/Canta-theme/blob/db96a1e27e131e4a0fad1e7e2b656179db46b5e8/src/_sass/gtk/apps/_mate.scss#L286
The large size results in various bug reports and issues like:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=456345
zim-desktop-wiki/zim-desktop-wiki#342
geany/geany#1825
https://unix.stackexchange.com/questions/271042/gtk3-statusbar-height
And C-based fixes like:
https://git.xfce.org/apps/ristretto/commit/?id=289329
https://github.com/xfce-mirror/thunar/blob/fe53f759991f3e5df89a4496dc9b353d0560b762/thunar/thunar-statusbar.c#L111
I've read that this has been fixed in Cinnamon and Unity themes, presumably in a similar fashion, but I don't have any of those to test.
It seems like a bad fix for every individual application to be forcing the margins to zero in C code, which is why I made this PR here. At least it would fix all XFCE apps with the default theme.
NOTE: This isn't tested, I don't know much about SASS, and I'm not sure that
2pxis the best value, I just wanted to see if something could be done about the large status bar.