Deprecate elementary-xfce-darkest #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variant used elementary-xfce as a fallback and symlinked the faux symbolic toolbar icons from xfce-darker. It now falls back entirely to elementary-xfce and its description is changed to indicate this.
newhoa
force-pushed
the
remove-elementary-xfce-darkest
branch
from
a78e443
to
0170b72
Compare
|
@bluesabre Do you have any thoughts on this from a distributor's perspective? |
|
@ochosi I'm actually not sure. I think with Debian packages we have some flexibility for interacting with user sessions (such as changing the selected theme in gsettings), but I'm not sure how "acceptable" that is. @Unit193 (not sure if that tag will work) might have better insight. @m4u9 can also comment from an openSUSE/RPM perspective. |
|
It worked! A Debian package can't touch user settings, no. |
|
No issues from an openSUSE perspective. We already leave out the darkest variant from the rpm installation. |
|
Thanks all! Let's move on with this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variant used elementary-xfce as a fallback and
symlinked the faux symbolic toolbar icons from xfce-darker.
It now falls back entirely to elementary-xfce and
its description is changed to indicate this.