Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The function
generate_meshgrid
allows to generate coordinates according to an affine transformation.This PR fixes several problems with
generate_meshgrid
:np.apply_affine
which does the dot product correctly. See generate_meshgrid bug for some affine transformations #167np.zeros_like
to floats to avoid rounding errorstest_siemens_basis
to correct for the rounding errorsgenerate_meshgrid
Linked issues
Fixes #167