Fix read_nii not looking for ImageComments and ImageType #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcohenadad
approved these changes
Nov 11, 2020
kousu
pushed a commit
that referenced
this pull request
Mar 20, 2021
* Make sure ImageComments and ImageType is in the json structure before reading their content * Added newline * Added test for nifti in realtime_zshimming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Read_nii allows to return nibabel, json and the numpy array by simply providing the nifti filename. It can also automatically scale the phase from Siemens to radians provided the input is appropriately labeled.
The PR fixes a bug where if the fields ImageComments or ImageType were not included in the json file, read_nii would crash. It will now behave correctly (not crash) and simply not scale to radians.
Linked issues
Fixes #170