Fix singleton on last dimension error in prelude #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
po09i
changed the title
jcohenadad
reviewed
Nov 12, 2020
jcohenadad
reviewed
Nov 12, 2020
jcohenadad
reviewed
Nov 12, 2020
jcohenadad
approved these changes
Nov 14, 2020
kousu
pushed a commit
that referenced
this pull request
Mar 20, 2021
* Add an extra dimension for each missing dimension * Add tests for singleton 2nd dim, 3rd dim, 2nd and 3rd dim * Apply comments from code review * Updated comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue in the prelude wrapper that returned the wrong number of dimensions if the input had a singleton in the last dimension. The fix looks at the input and compares it to the output to return the appropriate number of dimensions. This allows to also fix a case where both last dimensions would be 1. I've added tests for all cases (X,Y,1), (X,1) and (X,1,1)
Linked issues
Fixes #174