Change prelude mag parameter to be an optional argument #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
po09i
added
the
refactoring
|
Relevant for #169 |
jcohenadad
approved these changes
Nov 25, 2020
po09i
changed the title
po09i
changed the title
kousu
pushed a commit
that referenced
this pull request
Mar 20, 2021
* Move mag to non default parameter * Modify calls to prelude, make tests faster * Move mag comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fsl_prelude called by our
preludewrapper requires amaginput argument. Ifmagis not available or we don't want to mask the fieldmap,magcan be a matrix full of ones.This PR changes the default behaviour of
preludeto not require themagargument and sets the default value of mag to be a matrix full of ones.The tests and different calls to
preludewere changed to call prelude appropriately.