Fix local error with load_nifti #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
this PR suggests we should extend our testing platform to other OSs-- issue opened #180 |
jidicula
approved these changes
Nov 29, 2020
kousu
pushed a commit
that referenced
this pull request
Mar 20, 2021
* Sort list * Change echo numbers in test * Sort another list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Load_nifti does not pass locally on mac but passes on travis. This PR attempts to sort the list in load_nifti to get a consistent output across platforms.
The tests for multiple echoes had to be changed to reflect the sorted list.
Linked issues
Fixes #130