Rename phasediff image in dicom_to_nifti #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
po09i
added this to In progress
in Get a CLI based working example script
via automation
jcohenadad
reviewed
Dec 3, 2020
jcohenadad
requested changes
Dec 3, 2020
Get a CLI based working example script
automation
moved this from In progress
to Review in progress
Dec 3, 2020
I may have misled you in our internal meeting. This PR only changes the name of the output phasediff from sub-XX_phase2.nii.gz and sub-XX_phase2.json to sub-XX_phasediff.nii.gz and sub-XX_phasediff.json. The relevant function which creates the json file for the fieldmap is I opened an issue to add the test to the relevant function #194 |
jcohenadad
approved these changes
Dec 3, 2020
Get a CLI based working example script
automation
moved this from Review in progress
to Reviewer approved
Dec 3, 2020
Get a CLI based working example script
automation
moved this from Reviewer approved
to Done
Dec 3, 2020
kousu
pushed a commit
that referenced
this pull request
Mar 20, 2021
* Add phasediff instead of phase for phasediff images * Add potential issue where phasediff could be in the subject id * Add check on sequence name * account for .nii and .nii.gz * Remove .nii
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in dicom_to_nifti where phasediff images were wrongly indentified in their filenames as phase images instead of phasediff images.
The function looks at the output of dcm2bids and if
It will rename the json and the nifti to phasediff.
A test was changed to reflect the new names.
Linked issues
Fixes #190