New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shim CLI and sequencer #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
po09i
added
feature
Introduces a new functionality
Epic
General collection of features that will be sub-divided
labels
Aug 25, 2021
…_sequencer and added output to a txt file
gaspardcereza
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and it works just fine. I went through the code and didn't spot any mistake/typo. LGTM !
po09i
commented
Dec 18, 2021
… lower than a threshold
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to shim using the sequencer through
st_b0shim
. More precisely, the PR adds:st_b0shim
CLIst_b0shim
argument to use the sequencer (st_b0shim static
,st_b0shim realtime
,st_b0shim gradient_realtime
)st_b0shim
argument to define slices (st_b0shim define_slices
) (Removed)Coil
slicewise-ch
,chronological-ch
,eva
To test
Run the tests in test/cli/test_cli_b0shim
Related
Fixes #101
Related to #297