Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic python package setup #4

Merged
merged 3 commits into from Jul 4, 2020
Merged

Add basic python package setup #4

merged 3 commits into from Jul 4, 2020

Conversation

mathieuboudreau
Copy link
Member

Resolves #3

@jcohenadad
Copy link
Member

wow cool, github now shows travis builds inside github: https://github.com/shimming-toolbox/shimming-toolbox-py/pull/4/checks?check_run_id=835989940

jcohenadad
jcohenadad approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mathieuboudreau for getting the machine started 🙏

@mathieuboudreau mathieuboudreau merged commit 61ddcfc into master Jul 4, 2020
@mathieuboudreau mathieuboudreau deleted the mb/setup branch July 4, 2020 01:39
@mathieuboudreau mathieuboudreau mentioned this pull request Jul 9, 2020
Merged
2 tasks
kousu pushed a commit that referenced this pull request Mar 20, 2021
@mathieuboudreau
Merge pull request #4 from shimming-toolbox/mb/setup
6eef5aa 
Add basic python package setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcohenadad jcohenadad jcohenadad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up unit test suite
2 participants
@mathieuboudreau @jcohenadad