Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve real-time shimming #462

Merged
merged 9 commits into from Aug 31, 2023
Merged

Improve real-time shimming #462

merged 9 commits into from Aug 31, 2023

Conversation

po09i
Copy link
Member

@po09i po09i commented Jun 27, 2023 •
edited

Description

This PR aims at improving real-time shimming functionalities. More precisely,

  • It improves a plot showing the variation of the pressure probe along with the variation of the B0 field
  • Used RMSE instead of the MAE (sum of the absolute values) for some other plots
  • Output plots for different slices in a separate directory rather than a single long figure

@po09i po09i self-assigned this Jun 27, 2023
@po09i po09i added the enhancement New feature or request label Jun 27, 2023
@po09i po09i marked this pull request as ready for review August 29, 2023 21:48
@po09i po09i requested a review from 4rnaudB August 29, 2023 21:48
4rnaudB
4rnaudB reviewed Aug 30, 2023
View reviewed changes
shimmingtoolbox/pmu.py Show resolved Hide resolved
shimmingtoolbox/shim/sequencer.py Outdated Show resolved Hide resolved
shimmingtoolbox/shim/sequencer.py Outdated Show resolved Hide resolved
shimmingtoolbox/shim/sequencer.py Show resolved Hide resolved
@po09i po09i merged commit db0364e into master Aug 31, 2023
7 checks passed
@po09i po09i deleted the ad/rt-shim-improvements branch August 31, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4rnaudB 4rnaudB 4rnaudB approved these changes

Assignees

@po09i po09i

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@po09i @4rnaudB