Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows compatibility #469

Merged
merged 19 commits into from Aug 22, 2023
Merged

Add windows compatibility #469

merged 19 commits into from Aug 22, 2023

Conversation

po09i
Copy link
Member

@po09i po09i commented Aug 8, 2023

Description

This PR add windows compatibility to the toolbox

In more details:

  • Adds a .bat script to install Shimming Toolbox
  • Make modifications to ensure "all" features work (All tests are passing except prelude and sct tests since I have not installed them)
  • Solve unwrapper issue (We only natively support prelude which seems to only be installable on linux/Macs, Implement skimage's phase unwrapper #473 implemented skimage so we have an unwrapper installed)
  • Add windows installation section

A future PR should add windows installation and testing in the CI

@po09i po09i self-assigned this Aug 8, 2023
@po09i po09i requested a review from 4rnaudB August 9, 2023 17:47
@4rnaudB
Copy link
Member

4rnaudB commented Aug 11, 2023

st_b0shim dynamic works well. Create field maps doesn't work and I couldn't do the create coil profiles tutorial because of the bash commands

@po09i
Copy link
Member Author

po09i commented Aug 11, 2023

Thanks for testing it out!

st_b0shim dynamic works well. Create field maps doesn't work and I couldn't do the create coil profiles tutorial because of the bash commands

I believe prelude does is not available on windows (FSL recommends installing it through WSL). Therefore I would not expect it to work, is that the error message you get? Good point about the tutorial, they will need to be updated.

shimmingtoolbox/cli/check_env.py Outdated Show resolved Hide resolved
shimmingtoolbox/cli/check_env.py Outdated Show resolved Hide resolved
shimmingtoolbox/unwrap/skimage_unwrap.py Outdated Show resolved Hide resolved
shimmingtoolbox/unwrap/skimage_unwrap.py Outdated Show resolved Hide resolved
@po09i po09i merged commit 6d4260b into master Aug 22, 2023
7 checks passed
@po09i po09i deleted the ad/windows-compatibility branch August 22, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants