Dockerfile: switch to alpine base image #12
+24
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
To optimize for caching; only re-install dependencies if the list of dependencies changed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
So that it doesn't run as subprocess of `/bin/sh` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Because it's a bit smaller;
REPOSITORY TAG IMAGE ID CREATED SIZE
docker/pycreds-test alpine 2451e1c13a9e 3 seconds ago 134MB
docker/pycreds-test latest 70526611619f 10 minutes ago 951MB
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
dockerfile_alpine
branch
from
79d94b6
to
93b242d
Compare
thaJeztah
commented
Oct 7, 2019
| curl | ||
|
|
||
| # TODO remove once pass is in the main repository | ||
| RUN apk add --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing pass |
There was a problem hiding this comment.
I should probably note here that edge packages are not guaranteed to work with stable, so while this one currently does, it's possible that this may break on a future update of stable (or the edge package)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to https://github.com/shin-/dockerpy-creds/pull/11, but the
passpackage is not yet in the "stable" Alpine package index, so perhaps you didn't want that.The alpine image makes the image quite a bit smaller;