Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for API 26+ #32

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Added support for API 26+ #32

merged 2 commits into from
Jul 17, 2018

Conversation

ALXKAY
Copy link
Contributor

@ALXKAY ALXKAY commented Jul 17, 2018 •
edited

  • Updated compileSdkVersion and targetSdkVersion to 27
  • Updated Gradle to 4.9
  • Updated Android Plugin for Gradle to 3.1.3

@ALXKAY
- Added support for API 26+
e6c4eee 
- Updated compileSdkVersion and targetSdkVersion to 27
- Updated Gradle to 3.1.3
shineM
shineM reviewed Jul 17, 2018
View reviewed changes
treeview_lib/src/main/java/me/texy/treeview/animator/DefaultItemAnimator.java Outdated
if (sTimeInterpolator == null) {
sTimeInterpolator = new ValueAnimator().getInterpolator();
}
holder.itemView.animate().setInterpolator(sTimeInterpolator);
endAnimation(holder);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is these changes necessary？

Copy link
Contributor Author

@ALXKAY ALXKAY Jul 17, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I removed the redundant code. Please review my new commit.

@shineM
Copy link
Owner

shineM commented Jul 17, 2018

Thanks for your PR，I would merge this commit except for change in DefaultItemAnimator.java

@shineM shineM merged commit 8e0ae48 into shineM:master Jul 17, 2018
@ALXKAY
Copy link
Contributor Author

ALXKAY commented Jul 17, 2018

Please release a new version with these changes. I want to implement your library from Maven. Thanks!

@ALXKAY ALXKAY mentioned this pull request Jul 23, 2018
Closed
@shineM
Copy link
Owner

shineM commented Jul 25, 2018

New version 1.0.4 is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shineM shineM shineM left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ALXKAY @shineM