Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy_packages.pp correct aem_id handling #27

Closed
mbloch1986 opened this issue Mar 26, 2018 · 2 comments
Closed

deploy_packages.pp correct aem_id handling #27

mbloch1986 opened this issue Mar 26, 2018 · 2 comments
Assignees
Labels

Comments

@mbloch1986
Copy link
Contributor

The deploy artifacts has a logic inside, which sets the aem_id to the aem_id set in the descriptor file.

Since the descriptor file contains not always a aem_id, it needs to be set whether to the parameter from the hiera file or default 'author'. A realistic scenario where the aem_id is going to be set in the descriptor file is the consolidated instance.

@mbloch1986 mbloch1986 added the bug label Mar 26, 2018
@mbloch1986 mbloch1986 self-assigned this Mar 26, 2018
@mbloch1986
Copy link
Contributor Author

Following code line is infected:

$packages.each | Integer $index, Hash $package| {

$aem_id = $package[aem_id]

$final_sleep_seconds = pick(
  $package['sleep_seconds'],
  $sleep_seconds,
)

mbloch1986 added a commit to mbloch1986/puppet-aem-curator that referenced this issue Mar 26, 2018
mbloch1986 added a commit to mbloch1986/puppet-aem-resources that referenced this issue Mar 26, 2018
mbloch1986 added a commit to mbloch1986/puppet-aem-curator that referenced this issue Mar 26, 2018
mbloch1986 added a commit to mbloch1986/aem-aws-stack-provisioner that referenced this issue Mar 26, 2018
cliffano pushed a commit to shinesolutions/puppet-aem-curator that referenced this issue Mar 27, 2018
* Added aem_id parameter injecting to several action manifests

Regarding issue shinesolutions/puppet-aem-resources#27

* Changelog update

Regarding issue
shinesolutions/puppet-aem-resources#27

* Updates action download artifacts manifest

updated action download artifacts manifest to use aem_id

* Fixed error of variable reassign

* Updated parameter author_host and publish_host

* Updated aem_id handling from if else & selector to pick
cliffano pushed a commit that referenced this issue Mar 27, 2018
* Added aem_id handling to deploy_packages

For passing the aem_id variable to aem_pckage the aem_id handling needs
to improve so it's accepting the aem_id injected from the provisioner.

* Changelog update

Regarding issue
#27

* Fixed error of variable reassign

* Updated aem_id handling from if else & selector to pick
@cliffano
Copy link
Collaborator

Done. Included in 2.2.2 .

cliffano pushed a commit to shinesolutions/aem-aws-stack-provisioner that referenced this issue Apr 6, 2018
* Added new parameter aem_id for several aem_curator::action manifests.

* Changelog update

Regarding issue
shinesolutions/puppet-aem-resources#27

* Added new parameter for action manifest download_artifacts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants