Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GA properties around button in signup form #336

Merged
merged 2 commits into from Nov 7, 2018
Merged

Conversation

sandymak
Copy link
Contributor

@sandymak sandymak commented Nov 7, 2018

What’s this PR do?

  • Remove GA properties around button in signup form. This event will be tracked through GTM (google tag manager)

How was this tested? How should this be reviewed?

  • tested in staging (signup on form & get text & user is updated)

What are the relevant tickets?

Questions / Considerations

❗️ Existing users can get this text. Is this okay?
❌ Need to have copy checked prior to launching

@sandymak sandymak merged commit 2b55206 into dev Nov 7, 2018
@sandymak sandymak deleted the fb-ad-page branch November 7, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant