Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STRING to BQ_DATA_TYPE_DIC["STRING"] to support STRING data type #62

Merged

Conversation

manuelzander
Copy link
Contributor

@manuelzander manuelzander commented Oct 27, 2020

Summary

Added STRING to BQ_DATA_TYPE_DIC["STRING"] to support schema conversion when DDL contains STRING data type (for example BigQuery DDLs, see https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#string_type).

Added

  • STRING to BQ_DATA_TYPE_DIC["STRING"]
  • Unit-test to reflect above

Changed

  • n/a

Removed

  • n/a

Fixed

  • n/a

File Details

ddlparse/ddlparse.py

  • See above

Applicable Issues

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          390       390           
=========================================
  Hits           390       390           
Impacted Files Coverage Δ
ddlparse/ddlparse.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3ec0b...be97cf0. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 813754d on manuelzander:bq-datatype-patch into de3ec0b on shinichi-takii:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 813754d on manuelzander:bq-datatype-patch into de3ec0b on shinichi-takii:master.

Copy link
Owner

@shinichi-takii shinichi-takii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuelzander

LGTM!🎉
Thank you for the pull request.

@shinichi-takii shinichi-takii merged commit 680714f into shinichi-takii:master Nov 2, 2020
@manuelzander
Copy link
Contributor Author

@manuelzander

LGTM!🎉
Thank you for the pull request.

Great, happy to help 😊🎉

@manuelzander manuelzander deleted the bq-datatype-patch branch November 2, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants