Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basemodule bad work() signature #1500

Closed
wants to merge 2 commits into from
Closed

Fix basemodule bad work() signature #1500

wants to merge 2 commits into from

Conversation

gst
Copy link
Contributor

@gst gst commented Feb 6, 2015

Fix: BaseModule.work() signature not compatible with how Worker use and call it

nb: actually this method is only be used by "Satellite" daemons (poller, reactionner, receiver) for their external worker modules.

Grégory Starck added 2 commits February 6, 2015 10:54
nb: actually this method is only be used by "Satellite" daemons (poller, reactionner, receiver) for their external worker modules.
@gst gst changed the title Fix basemodule bad work Fix basemodule bad work() signature Feb 6, 2015
@Seb-Solon
Copy link
Contributor

Receiver does not use it actually.

Do you have any test to add ? Like try to load a module and see that this is the new work method that is used to create the process.

@gst
Copy link
Contributor Author

gst commented Feb 6, 2015

Do you have any test to add ? Like try to load a module and see that this is the new work method that is used to create the process.

The main method used by the worker processes has not changed (work()), only its signature, to match how it's actually called.

@Seb-Solon
Copy link
Contributor

I was more thinking about assert module.work something. Because I think previosuly a print module.work was returning something like basemodule.main function

The assert may be something where you have the target assignment I don't know if it's easy to exec this specific part of code without huge copy paste / run everything.

@Seb-Solon Seb-Solon modified the milestone: 2.6 () Mar 9, 2015
@gst gst closed this May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants