HTML mail notifications fix and improvements #1746
Conversation
mohierf
commented
Nov 3, 2015
mohierf
commented
- fix Mail notification - encoding exception not catched #1745 exception
- add an option to specify the mail sender (-s me@myserver.com) instead of default one
- use WebUI2 company logo if defined, or default logo if not
- use WebUI2 port for webui url
- add an option to specify the WebUI root part of URL
- updated doc
Allow to set the mail sender as to not always use root@shinken.main
- search the logo in WebUI2 configuration - search WebUI port in WebUI2 configuration - added an option to set WebUI URL
|
I've merged another PR with the sender option. I will merge this PR soon, after new travis tests |
|
I am quite disappointed with your merge strategy ... amongst the 3 PR dealing with a sender option, you choose not to merge this one which also included some fixes, a better integration with Web UI and some doc ! What a strange choice ... |
|
Yes i am sorry about this one. My strategy was simple : start with the
|
|
Why include that on shinken core ? I think you must use mod -> https://shinken.readthedocs.org/en/latest/14_contributing/modules.html. |
|
@mohierf , could you manage the conflicts (again sorry about that :( ). |
... host macros are only state and duration !
|
@olivierHa : I do not see any conflicts anymore now ... |
|
@olivierHa : I modified the PR and I see that there are still conflicts ... but I do not find them ! |
…-notification # Conflicts: # libexec/notify_by_email.py
- use "Service state duration" instead of "Service duration" - use "Host state duration" instead of "Host duration"
|
I included #1749 modifications in the last commit of this PR. |
HTML mail notifications fix and improvements
|
Thanks a lot ! |
…#1749 Sorry for this bad merge ...
