Update typographic errors and explain things in the help messages #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message for --debug is not obvious because it doesn't explain that it enables a different logging scheme (a more verbose log is captured). Additionally, self-claiming that the program is bug-free is not very useful when you're debugging a serious bug.
|
I've updated the branch now that @naparuba has finished fixing the pipelines, just so that everything looks green. 🍏📗💚 |
|
Thanks a lot :) |
mohierf
pushed a commit
to mohierf/shinken
that referenced
this pull request
Dec 3, 2019
…inken-solutions#1968) * Fix typographic error librairy -> library * Update help message for --debug flag The message for --debug is not obvious because it doesn't explain that it enables a different logging scheme (a more verbose log is captured). Additionally, self-claiming that the program is bug-free is not very useful when you're debugging a serious bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few typographic errors that I found in the help message (such as librairy), and also rewrites some help strings for some flags to make their purpose more easier to understand.